Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust axis ranges of DQM plots for track residuals ( 13_0_X ) #41675

Merged
merged 1 commit into from
May 17, 2023
Merged

Adjust axis ranges of DQM plots for track residuals ( 13_0_X ) #41675

merged 1 commit into from
May 17, 2023

Conversation

mteroerd
Copy link
Contributor

backport of #41652

PR description:

Adjusting the axis range of the booked histograms so it's easier to make out details of the distributions. Currently, the histogram ranges are booked to widely, e.g., https://tinyurl.com/2hjte4dz and https://tinyurl.com/2hv57zaq

PR validation:

The changes should be transparent. Passes basic compilation tests

If this PR is a backport please specify the original PR and why you need to backport that PR:

The change is needed in this release for DQM. Original PR: #41652

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone May 15, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2023 •
edited
Loading

A new Pull Request was created by @mteroerd (Marius Teroerde) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/SiPixelPhase1Track (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented May 15, 2023

@mteroerd please create also a backport for 13.1.X

@mmusich
Copy link
Contributor

mmusich commented May 15, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd1b42/32640/summary.html
COMMIT: 78a41cd
CMSSW: CMSSW_13_0_X_2023-05-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41675/32640/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555563
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 180
  • DQMHistoTests: Total successes: 3555348
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c9d3641 into cms-sw:CMSSW_13_0_X May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed orp-approved tests-approved trk
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mteroerd @cmsbuild @mmusich @emanueleusai @perrotta